fix(YouTube - Bottom buttons): Adjust bottom buttons layout #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does the incorrect margin happen to begin with? |
|
i have this problem on the original youtube 19.22.34 and since the first use of revanced.
|
|
In that case, this should be first reported to YouTube and fixed by them. The patch is overly complex for a minuscule gain. Thanks regardless. Also, to avoid work like this being closed, please always open an issue for discussion first as described in the contribution guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the clicking effect of the bottom buttons by adding the layout_marginBottom attribute (I think 6.0dip will be fine, see screenshots).
Resizes the button's container to fit better relative to each other to somewhat prevent the stacking effect on other elements (60x60 originally, 48x48 now).
It should also be noted that in YouTube 19.09+ fullscreen_button has been moved from youtube_controls_bottom_ui_container to other layouts, so it is necessary to change the attributes for them.
Before
After