Skip to content

Commit

Permalink
Remove anchor when data-tooltip-id gets changed
Browse files Browse the repository at this point in the history
  • Loading branch information
mixrich authored and gabrieljablonski committed Jan 21, 2024
1 parent 0b395a4 commit 6d2a880
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/components/Tooltip/Tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@ const Tooltip = ({
const newId = (mutation.target as HTMLElement).getAttribute('data-tooltip-id')
if (newId === id) {
newAnchors.push(mutation.target as HTMLElement)
} else if (mutation.oldValue === id) {
// data-tooltip-id has now been changed, so we need to remove this anchor
removedAnchors.push(mutation.target as HTMLElement)
}
}
if (mutation.type !== 'childList') {
Expand Down Expand Up @@ -727,6 +730,8 @@ const Tooltip = ({
subtree: true,
attributes: true,
attributeFilter: ['data-tooltip-id'],
// to track the prev value if we need to remove anchor when data-tooltip-id gets changed
attributeOldValue: true,
})
return () => {
documentObserver.disconnect()
Expand Down

0 comments on commit 6d2a880

Please sign in to comment.