Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just(T) : RxJavaObservableExecutionHook not called #2656

Closed
ronanM opened this issue Feb 13, 2015 · 6 comments
Closed

just(T) : RxJavaObservableExecutionHook not called #2656

ronanM opened this issue Feb 13, 2015 · 6 comments
Labels
Bug
Milestone
1.0.x

Comments

@ronanM
Copy link

ronanM commented Feb 13, 2015

When using rx.Observable.just(T) the RxJavaObservableExecutionHook is not call.

This is not like other just(T,...) that call rx.Observable.from(Iterable<? extends T>).
@benjchristensen benjchristensen added this to the 1.0.x milestone Feb 16, 2015
@benjchristensen
Copy link
Member

Thanks for the report.

@benjchristensen
Copy link
Member

@abersnaze Since this probably affects work you're doing as well, can you take a look at what we need to fix here? It will be anything using the internal ScalarSynchronousObservable optimization I think.

@abersnaze
Copy link
Contributor

sure.

@akarnokd
Copy link
Member

What is the status of this issue? I've lost track of the proposed changes to ScalarSynchronousObservable.

@akarnokd akarnokd mentioned this issue May 21, 2016
Merged
@akarnokd
Copy link
Member

See #3958.

zsxwing pushed a commit that referenced this issue May 23, 2016
@akarnokd @zsxwing
1.x: just() construction to call the onCreate execution hook (#3958)
3ea9265 
This PR adds the call to RxJavaObservableExecutionHook.onCreate() to the just() - ScalarSynchronousObservable construction.

Related: #2656.
@zsxwing
Copy link
Member

zsxwing commented May 23, 2016

Closing via #3958

@zsxwing zsxwing closed this as completed May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.0.x
Development

No branches or pull requests
5 participants
@abersnaze @benjchristensen @ronanM @zsxwing @akarnokd