Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: explain null plugin returns better #6172

Closed
akarnokd opened this issue Aug 25, 2018 · 2 comments
Closed

2.x: explain null plugin returns better #6172

akarnokd opened this issue Aug 25, 2018 · 2 comments

Comments

@akarnokd
Copy link
Member

akarnokd commented Aug 25, 2018

When an onSubscribe hook is installed and returns a null consumer, the current error report says:

ObjectHelper.requireNonNull(observer, "Plugin returned null Observer");

At least an "a" is missing but perhaps it would be better to word it more detailed:

"The RxJavaPlugins.onSubscribe hook returned a null Observer. Please check the handler provided to RxJavaPlugins.setOnObservableSubscribe for invalid null returns. Further reading: https://github.com/ReactiveX/RxJava/wiki/Plugins"

Of course, all reactive types should be updated and adapted to the appropriate types and method names.

@logan-firefly
Copy link

I'm inexperienced but I would be a happy to try and help with this issue.

@akarnokd
Copy link
Member Author

Closing via #6175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants