2.x: explain null observer/subscriber error reports in detail from RxJavaPlugins #6175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #6172.
With these changes, all reactive types will emit detailed error message when
onSubscribe
hook installed using RxJavaPlugins returns nullobserver/subscriber
:Observable
Flowable
Single
Maybe
Completable
Note :
There was no null check on
observer
returned fromRxJavaPlugins.onSubscribe(this, observer)
method call inCompletable
's subscribe() method.So, I've added it in this PR. Is that fine?