Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SynchronizedObserverTest.testMultiThreadedWithNPEinMiddle fails #872

Closed
akarnokd opened this issue Feb 13, 2014 · 1 comment
Closed

SynchronizedObserverTest.testMultiThreadedWithNPEinMiddle fails #872

akarnokd opened this issue Feb 13, 2014 · 1 comment

Comments

@akarnokd
Copy link
Member

If I run just the test file, it succeeds. If I run a complete build, it fails due to receiving 9 onNext calls most of the time. Shouldn't SynchronizedObserver also ensure event semantics as well as synchronization?
(Tested on i7 4770K @ 3.5GHz; 4/8 cores).
benjchristensen added a commit to benjchristensen/RxJava that referenced this issue Feb 18, 2014
@benjchristensen
Synchronized Operator Check for isTerminated
f74bb41 
As per ReactiveX#872 make Synchronized reject events after terminal state.
This class should not unsubscribe though. That is only for SafeSubscriber at the end.
@benjchristensen benjchristensen mentioned this issue Feb 18, 2014
Merged
@benjchristensen
Copy link
Member

It's a good safety-net to keep, but it shouldn't do any of the error handling or unsubscribe logic of SafeSubscriber. Thanks for pointing it out.

jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
@obfuscoder
Update prometheus simpleclient dependency to 0.8.1 (ReactiveX#872)
3c31816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjchristensen @akarnokd