Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facilities for creating Observables from JavaFX events and ObservableValues #1182

Merged
merged 1 commit into from
May 9, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions rxjava-contrib/rxjava-javafx/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
apply plugin: 'osgi'

sourceCompatibility = JavaVersion.VERSION_1_6
targetCompatibility = JavaVersion.VERSION_1_6

dependencies {
compile project(':rxjava-core')
provided 'junit:junit-dep:4.10'
provided 'org.mockito:mockito-core:1.8.5'
}

javadoc {
options {
doclet = "org.benjchristensen.doclet.DocletExclude"
docletpath = [rootProject.file('./gradle/doclet-exclude.jar')]
stylesheetFile = rootProject.file('./gradle/javadocStyleSheet.css')
windowTitle = "RxJava Javadoc ${project.version}"
}
options.addStringOption('top').value = '<h2 class="title" style="padding-top:40px">RxJava</h2>'
}

jar {
manifest {
name = 'rxjava-javafx'
instruction 'Bundle-Vendor', 'Netflix'
instruction 'Bundle-DocURL', 'https://github.com/Netflix/RxJava'
instruction 'Import-Package', '!org.junit,!junit.framework,!org.mockito.*,*'
instruction 'Fragment-Host', 'com.netflix.rxjava.core'
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
package rx.javafx.sources;

import javafx.event.Event;
import javafx.event.EventHandler;
import javafx.event.EventType;
import javafx.scene.Node;
import rx.Observable;
import rx.Subscriber;
import rx.functions.Action0;
import rx.schedulers.JavaFxScheduler;
import rx.subscriptions.JavaFxSubscriptions;

public class NodeEventSource {
/**
* @see rx.observables.JavaFxObservable#fromNodeEvents
*/
public static <T extends Event> Observable<T> fromNodeEvents(final Node source, final EventType<T> eventType) {

return Observable.create(new Observable.OnSubscribe<T>() {
@Override
public void call(final Subscriber<? super T> subscriber) {
final EventHandler<T> handler = new EventHandler<T>() {
@Override
public void handle(T t) {
subscriber.onNext(t);
}
};

source.addEventHandler(eventType, handler);

subscriber.add(JavaFxSubscriptions.unsubscribeInEventDispatchThread(new Action0() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be safely handling unsubscribe by doing it in the right thread so 'unsubscribeOn' is not needed.

@Override
public void call() {
source.removeEventHandler(eventType, handler);
}
}));
}

}).subscribeOn(JavaFxScheduler.getInstance());
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
package rx.javafx.sources;

import javafx.beans.value.ChangeListener;
import javafx.beans.value.ObservableValue;
import rx.Observable;
import rx.Subscriber;
import rx.functions.Action0;
import rx.subscriptions.JavaFxSubscriptions;

public class ObservableValueSource {

/**
* @see rx.observables.JavaFxObservable#fromObservableValue
*/
public static <T> Observable<T> fromObservableValue(final ObservableValue<T> fxObservable) {
return Observable.create(new Observable.OnSubscribe<T>() {
@Override
public void call(final Subscriber<? super T> subscriber) {
subscriber.onNext(fxObservable.getValue());

final ChangeListener<T> listener = new ChangeListener<T>() {
@Override
public void changed(final ObservableValue<? extends T> observableValue, final T prev, final T current) {
subscriber.onNext(current);
}
};

fxObservable.addListener(listener);

subscriber.add(JavaFxSubscriptions.unsubscribeInEventDispatchThread(new Action0() {
@Override
public void call() {
fxObservable.removeListener(listener);
}
}));

}
});
}


}
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/**
* Copyright 2014 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package rx.observables;


import javafx.beans.value.ObservableValue;
import javafx.event.Event;
import javafx.event.EventType;
import javafx.scene.Node;
import rx.Observable;
import rx.javafx.sources.NodeEventSource;
import rx.javafx.sources.ObservableValueSource;


public enum JavaFxObservable {
; // no instances


/**
* Creates an observable corresponding to javafx ui events.
*
* @param node The target of the UI events.
* @param eventType The type of the observed UI events
* @return An Observable of UI events, appropriately typed
*/
public static <T extends Event> Observable<T> fromNodeEvents(final Node node, final EventType<T> eventType) {
return NodeEventSource.fromNodeEvents(node, eventType);
}

/**
* Create an rx Observable from a javafx ObservableValue
*
* @param fxObservable the observed ObservableValue
* @param <T> the type of the observed value
* @return an Observable emitting values as the wrapped ObservableValue changes
*/
public static <T> Observable<T> fromObservableValue(final ObservableValue<T> fxObservable) {
return ObservableValueSource.fromObservableValue(fxObservable);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
/**
* Copyright 2014 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package rx.schedulers;

import javafx.animation.KeyFrame;
import javafx.animation.Timeline;
import javafx.application.Platform;
import javafx.event.ActionEvent;
import javafx.event.EventHandler;
import javafx.util.Duration;
import rx.Scheduler;
import rx.Subscription;
import rx.functions.Action0;
import rx.subscriptions.BooleanSubscription;
import rx.subscriptions.CompositeSubscription;
import rx.subscriptions.Subscriptions;

import java.util.concurrent.TimeUnit;

/**
* Executes work on the JavaFx UI thread.
* This scheduler should only be used with actions that execute quickly.
*/
public final class JavaFxScheduler extends Scheduler {
private static final JavaFxScheduler INSTANCE = new JavaFxScheduler();

/* package for unit test */JavaFxScheduler() {
}

public static JavaFxScheduler getInstance() {
return INSTANCE;
}

private static void assertThatTheDelayIsValidForTheJavaFxTimer(long delay) {
if (delay < 0 || delay > Integer.MAX_VALUE) {
throw new IllegalArgumentException(String.format("The JavaFx timer only accepts non-negative delays up to %d milliseconds.", Integer.MAX_VALUE));
}
}

@Override
public Worker createWorker() {
return new InnerJavaFxScheduler();
}

private static class InnerJavaFxScheduler extends Worker {

private final CompositeSubscription innerSubscription = new CompositeSubscription();

@Override
public void unsubscribe() {
innerSubscription.unsubscribe();
}

@Override
public boolean isUnsubscribed() {
return innerSubscription.isUnsubscribed();
}

@Override
public Subscription schedule(final Action0 action, long delayTime, TimeUnit unit) {
long delay = unit.toMillis(delayTime);
assertThatTheDelayIsValidForTheJavaFxTimer(delay);
final BooleanSubscription s = BooleanSubscription.create();

final Timeline timeline = new Timeline(new KeyFrame(Duration.millis(delay), new EventHandler<ActionEvent>() {

@Override
public void handle(ActionEvent event) {
if (innerSubscription.isUnsubscribed() || s.isUnsubscribed()) {
return;
}
action.call();
innerSubscription.remove(s);
}
}));

timeline.setCycleCount(1);
timeline.play();

innerSubscription.add(s);

// wrap for returning so it also removes it from the 'innerSubscription'
return Subscriptions.create(new Action0() {

@Override
public void call() {
timeline.stop();
s.unsubscribe();
innerSubscription.remove(s);
}

});
}

@Override
public Subscription schedule(final Action0 action) {
final BooleanSubscription s = BooleanSubscription.create();
Platform.runLater(new Runnable() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Platform.runLater not return a Future or handle that can be cancelled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Platform.runLater not return a Future or handle that can be cancelled?

Sadly, it doesn't, once queued, the Runnable cannot be cancelled but guaranteed to be run at a later time in the ui thread.

@Override
public void run() {
if (innerSubscription.isUnsubscribed() || s.isUnsubscribed()) {
return;
}
action.call();
innerSubscription.remove(s);
}
});

innerSubscription.add(s);
// wrap for returning so it also removes it from the 'innerSubscription'
return Subscriptions.create(new Action0() {

@Override
public void call() {
s.unsubscribe();
innerSubscription.remove(s);
}

});
}

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/**
* Copyright 2014 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package rx.subscriptions;


import javafx.application.Platform;
import rx.Scheduler.Worker;
import rx.Subscription;
import rx.functions.Action0;
import rx.schedulers.JavaFxScheduler;

public final class JavaFxSubscriptions {

private JavaFxSubscriptions() {
// no instance
}

/**
* Create an Subscription that always runs <code>unsubscribe</code> in the event dispatch thread.
*
* @param unsubscribe the action to be performed in the ui thread at un-subscription
* @return an Subscription that always runs <code>unsubscribe</code> in the event dispatch thread.
*/
public static Subscription unsubscribeInEventDispatchThread(final Action0 unsubscribe) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Basically a JavaFx version of 'unsubscribeOn'. This is better because it allows executing immediately if already in the right thread.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. Once the build issue is resolved I will merge it.

Thanks for contributing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I just merged it :-)

I'll have to fix the build later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news regarding the merge. I am concerned this innocuous breaks the build for other PR :(
I really suspect CloudBees is using OpenJDK, that, for license reason, do not include JavaFX. If this is the case, temporary disabling the gradle module seems the right short-term move, while CB updates to Oracle's or OpenJFX matures enough.
Thanks for your review and involvement!

return Subscriptions.create(new Action0() {
@Override
public void call() {
if (Platform.isFxApplicationThread()) {
unsubscribe.call();
} else {
final Worker inner = JavaFxScheduler.getInstance().createWorker();
inner.schedule(new Action0() {
@Override
public void call() {
unsubscribe.call();
inner.unsubscribe();
}
});
}
}
});
}
}
Loading