ReplaySubject enhancement with time and/or size bounds #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1130 SUCCESS |
| import rx.schedulers.TestScheduler; | ||
| import rx.subjects.PublishSubject; | ||
|
|
||
| public class OperatorReplayTest { | ||
| @Test | ||
| public void testBoundedList() { |
There was a problem hiding this comment.
Why are these unit tests being deleted? Are they invalid behavior?
There was a problem hiding this comment.
BTW ... I tried seeing if they had been moved, but I don't see the names of these tests elsewhere, so perhaps they were renamed?
There was a problem hiding this comment.
They were testing the internal virtual list implementation in the CustomReplaySubject. Now that it is gone, there is no need for the test.
|
Thank you for this refactor ... it looks like it was tedious! Just a simple question above and then will merge. |
benjchristensen
added a commit
that referenced
this pull request
May 20, 2014
ReplaySubject enhancement with time and/or size bounds
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapplied the enhancements to bring size and/or time bound
ReplaySubjectcapabilities while exposing a single subject class (i.e., no separate BoundedReplaySubject or CustomReplaySubject). It now uses the renewedSubjectSubscriptionManager.In addition, I've moved a confusing behavior from SubjectObserver into AsyncSubject where it belongs.