Ensuring Runnables posted with delay to a Handler are removed when unsub...

[dpsm]

...scribed.

This patch ensures the delayed runnables posted to a Handler are properly
removed when Subscription.unsubscribe() is called on the Observable.

The original code returns the subscription from schedule() but is not used
by the callers who instead add the Worker itself as a subsciption.

Signed-off-by: David Marques [email protected]

[benjchristensen]

/cc @akarnokd @zsxwing for review please.

[benjchristensen]

Thanks @dpsm for the contribution and fixes.

[cloudbees-pull-request-builder]

RxJava-pull-requests #1213 SUCCESS
This pull request looks good

[akarnokd]

Generally, the entire schedule(Action0, long, TimeUnit) is incorrect:

1. it has to return a valid subscription that cancels the submitted action: this PR returns an empty subscription which won't even cancel a direct schedule.
2. the action should to monitor its own cancellation token instead of the worker's overall subscription,
3. it has to track scheduled tasks; this is covered in this PR
4. it has to remove completed tasks from the tracking structure; in this PR, without it, the scheduler leaks subscriptions until terminated.

You need to introduce a new class similar to ScheduledAction which is itself a runnable and a Subscription: you can add it to the tracking composite and it can remove itself from the very same composite on completion, you can return it as the Subscription token and it can check itself before executing the actual action.

[cloudbees-pull-request-builder]

RxJava-pull-requests #1214 SUCCESS
This pull request looks good

[akarnokd]

You need to add the scheduledAction to the composite:

mCompositeSubscription.add(scheduledAction);

[cloudbees-pull-request-builder]

RxJava-pull-requests #1221 SUCCESS
This pull request looks good

[akarnokd]

The changes are now fine with me. @zsxwing ?

[zsxwing]

LGTM

[benjchristensen]

@mttkay Are you okay with these changes and their impact on Android?

[mttkay]

I don't think RxJava uses the Android code style anywhere. We shouldn't adopt it here.

[cloudbees-pull-request-builder]

RxJava-pull-requests #1241 SUCCESS
This pull request looks good

[mttkay]

👍

[dpsm]

@benjchristensen given everyone's approval when could we get it into master? I am new to the project and want to contribute a lot more specially in the android side of things! Is there anywhere I can read about the roadmap or some idea on release process, SNAPSHOT builds, etc? Thanks!

[benjchristensen]

You can read about the roadmap here: #1001

The plan is to split RxAndroid out into it's own top-level project at http://github.com/ReactiveX/RxAndroid in the next month or two.