-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RxScala: Add the rest missing methods to BlockingObservable #1336
Conversation
RxJava-pull-requests #1245 SUCCESS |
RxJava-pull-requests #1246 SUCCESS |
lastOption match { | ||
case Some(element) => element | ||
case None => default | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use Option.getOrElse to implement this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot it... Already updated.
RxJava-pull-requests #1252 SUCCESS |
LGTM |
In this context, why call
|
The reason why I changed I agree that having a |
Conflicts: language-adaptors/rxjava-scala/src/examples/scala/rx/lang/scala/examples/RxScalaDemo.scala
RxJava-pull-requests #1275 SUCCESS |
Is this ready to be merged and released in 0.19.1? |
imo yes |
@samuelgruetter Will you take adding proper |
@benjchristensen Sorry missed this yesterday. |
So ready for 0.19.2 ... or do you want another change @headinthebox ? |
@headinthebox I'm sorry I don't have time right now for |
OK, ill fix it over the weekend. |
@headinthebox, do you have time for this? If not, I can take it. |
@zsxwing I won't say no to that, go for it! |
RxJava-pull-requests #1284 SUCCESS |
I added |
Honestly, I actually don't care to much about def to[Col[_]]: Col[A]
def toArray: Array[A]
def toBuffer[B >: A]: Buffer[B]
def toIndexedSeq: immutable.IndexedSeq[A]
def toIterable: Iterable[A]
def toIterator: Iterator[A]
def toList: List[A]
def toMap[T, U]: Map[T, U]
def toParArray: ParArray[T]
def toSeq: Seq[A]
def toSet[B >: A]: immutable.Set[B]
def toStream: immutable.Stream[A]
def toString(): String
def toTraversable: Traversable[A]
de toVector: Vector[A] |
@headinthebox I removed the previous commit about |
RxJava-pull-requests #1285 SUCCESS |
RxScala: Add the rest missing methods to BlockingObservable
Some comments about this PR:
BlockingObservable[+T] private[scala] (val asJava: rx.observables.BlockingObservable[_ <: T])
toBlockingObservable[+T] private[scala] (val o: Observable[T])
so that we can implement logic inBlockingObservable
.toIterable
to implement***Option
and***OrElse
because if some exception happens, we can not unsubscribe the underlyingObservable
byIterable
at once./cc @headinthebox, @samuelgruetter