-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision of JMH Tests #1376
Revision of JMH Tests #1376
Conversation
- removal of all non-JMH perf tests
RxJava-pull-requests #1315 SUCCESS |
Sorry, not sure when I'll be able to review these changes. |
@nitsanw No problem, I know you're very busy. If you ever have the chance and interest, it would be good to know we're following your examples right. In the meantime though I'm pushing forward based on my current understandings of how to use JMH. I appreciate your responses and involvement in our project! |
My examples are very dated by now, you should look at the latest samples on the JMH project.
|
I ended up finding those after looking at yours, and went through them as well. I assume you're referring to these? http://hg.openjdk.java.net/code-tools/jmh/file/tip/jmh-samples/src/main/java/org/openjdk/jmh/samples/ |
Yes. :)
|
Hi there :) Not sure if that's intentional or not, but poking around a few benchmarks there, it seems you can make them even cleaner: instead of using the explicit That is, this sample works: |
This updates all perf testing to use only JMH. I tried to get all of them to follow a common pattern, and to comply with examples at https://github.com/nitsanw/jmh-samples/blob/master/src/main/java/org/openjdk/jmh/samples/ by @nitsanw. (@nitsanw if you're willing to take a look at this and confirm or correct them, I'd appreciate that).
I am doing this in 0.19 so that work on 0.20 has a common set of perf tests to use for comparison.