Composite Exception - Circular Reference Handling #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reverting to version that just does printStackTrace - see ReactiveX#1405
The printStackTrace and getCause implementations have different approaches to handling circular references. If on a JVM where printStackTrace is called directly, the full causal chain will always be printed. If on one such as Dalvik where getCause is invoked directly then it will cut the causal chain if it sees a duplicate.
|
RxJava-pull-requests #1534 SUCCESS |
|
This passed the Netflix production canary over night. There are no threads spinning on circular references. This pull request should work for both Android and Oracle JVMs as it supports both |
benjchristensen
added a commit
that referenced
this pull request
Aug 27, 2014
Composite Exception - Circular Reference Handling
This was referenced Aug 27, 2014
benjchristensen
added a commit
to benjchristensen/RxJava
that referenced
this pull request
Aug 27, 2014
ReactiveX#1632 Composite Exception - Circular Reference Handling ReactiveX#1631 Handle Fatal Exceptions in doOnEach
benjchristensen
added a commit
to benjchristensen/RxJava
that referenced
this pull request
Aug 27, 2014
Same change as ReactiveX#1632 against 0.20 for 1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The printStackTrace and getCause implementations have different approaches to handling circular references.
If on a JVM where printStackTrace is called directly, the full causal chain will always be printed. If on one such as Dalvik where getCause is invoked directly then it will cut the causal chain if it sees a duplicate.
See #1405