Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1812 that zip may swallow requests #1813

Merged
merged 1 commit into from
Oct 31, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Oct 31, 2014

Fixed #1812

@@ -227,7 +227,7 @@ void tick() {
if (COUNTER_UPDATER.getAndIncrement(this) == 0) {
do {
// we only emit if requested > 0
if (requested.get() > 0) {
while (requested.get() > 0) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjchristensen I cannot understand why this used if. Do you remember?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember.

@benjchristensen
Copy link
Member

Thanks for the fix.

benjchristensen added a commit that referenced this pull request Oct 31, 2014
Fix issue #1812 that zip may swallow requests
@benjchristensen benjchristensen merged commit c268471 into ReactiveX:1.x Oct 31, 2014
@zsxwing zsxwing deleted the issue1812 branch November 1, 2014 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants