-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with max concurrency now supports backpressure. #2540
Merge with max concurrency now supports backpressure. #2540
Conversation
I can't be sure, but probably the first Travis CI build timed out because the test used too many threads. |
Thanks for tackling this. Do you think it's better to keep this separate or to have a single |
I would have to combine merge, mergeDelayError and mergeMaxConcurrent. Adding error delaying to mmc shouldn't be difficult, but applying the scalar-synchronous-value optimization as well is quite difficult. I'd say let's have them separate for now. |
Keeping them separate means we'll be doing bug fixes and optimizations separately on each of them, and performance will be misleadingly different for each. I suggest that if we do merge this it is only a short-term thing.
|
It would be great if my other merge PR gets verified so I can base the joint operator on something that's actually working for others. |
I'm merging this for now as combining the two is difficult and I don't want to hold 1.0.5 release back. From then on, a single implementation would be just an internal affair. |
Merge with max concurrency now supports backpressure.
Agreed. |
See #2291