Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Corrected all Java interfaces declarations" #2849

Closed
wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Mar 30, 2015

Reverts #2807

Revert because they are breaking changes. RxScala needs the public modifier so that it can wrap them into Scala classes.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@JakeWharton
Copy link
Contributor

👎

All interface methods are public and abstract regardless of whether you declare them.
All interfaces are static when nested regardless of whether you declare it.

@zsxwing zsxwing closed this Mar 30, 2015
@zsxwing zsxwing deleted the revert-2807-correct-interfaces branch March 30, 2015 15:22
@akarnokd
Copy link
Member

Is this some kind of Scala compiler bug?

@zsxwing
Copy link
Member Author

zsxwing commented Mar 30, 2015

Is this some kind of Scala compiler bug?

No. I thought they were different. But since the byte codes are same, it won't break RxScala.

@artem-zinnatullin
Copy link
Contributor

LOL, it just can't be true, many Scala apps depend on Java code without public abstract modifiers in interfaces, I think it's a problem of mixing concepts "Interface" in Java and "Trait" in Scala, everything should work without these modifiers

@zsxwing
Copy link
Member Author

zsxwing commented Mar 30, 2015

LOL, it just can't be true, many Scala apps depend on Java code without public abstract modifiers in interfaces, I think it's a problem of mixing concepts "Interface" in Java and "Trait" in Scala, everything should work without these modifiers

Right. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants