OperatorSingle should request exactly what it needs #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // should request at most 2 in total to complete with no | ||
| // items, emit the single item or decide that there are | ||
| // too many items. | ||
| long numToRequest = Math.min(2 - requested.get(), n); |
There was a problem hiding this comment.
Why not request(2) once in this request()? I.e.,
public void request(long n) {
if (n > 0 && once.compareAndSet(false, true)) {
parent.requestMore(2);
}
}
|
yep, indeed. I got a bit caught up preserving the existing logic. I'll clean it up. |
davidmoten
force-pushed
the
OperatorSingle-request-accounting
branch
from
a73044a to
f8cee0a
Compare
davidmoten
force-pushed
the
OperatorSingle-request-accounting
branch
from
f8cee0a to
d51763d
Compare
|
there's a bit of a cleanup, have another look, thanks. |
|
Thanks. |
akarnokd
added a commit
that referenced
this pull request
Apr 7, 2015
…nting OperatorSingle should request exactly what it needs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
observable.single().subscribe()requestedLong.MAX_VALUEfromobservablewhich is more than it needs to come up with one item or an error. This PR sets aProducerforOperatorSingleso that it requests no more or less than it needs.