Use singleton Operators where we can #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please do |
| static final OperatorDistinct<?,?> INSTANCE = new OperatorDistinct<Object,Object>(UtilityFunctions.<Object>identity()); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") |
There was a problem hiding this comment.
I'd add a javadoc comment here so it is more apparent the returned instance uses the identity function for comparison.
davidmoten
force-pushed
the
single-singleton
branch
from
42e0cd0 to
1a5ce9a
Compare
… distinctUntilChanged, onBackpressureBuffer, isEmpty
davidmoten
force-pushed
the
single-singleton
branch
from
1a5ce9a to
1ef4d50
Compare
|
Updated javadoc and renamed |
|
unrelated CI failure. I'll open an issue for it. |
|
Looks good! |
akarnokd
added a commit
that referenced
this pull request
Apr 23, 2015
Use singleton Operators where we can
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce GC pressure use singleton
Operators forObservable.single,distinct,distinctUntilChanged,onBackpressureBuffer,isEmpty.