Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert of cache/replay #3081

Merged
merged 4 commits into from
Jul 20, 2015
Merged

Conversation

abersnaze
Copy link
Contributor

#3076. I did revert commit of the PR that added back pressure support to the cache operator and ran a canary. Our production systems seem stable now even with the new merge.

@davidmoten
Copy link
Collaborator

That's good news. Not sure what time @akarnokd has for reviewing .cache backpressure work. If we can't fix this short term would be nice too see a fix for #3026 go in 1.0.13 if backpressure doesn't make it. Quick summary is in 1.0.12 .cache emits nothing until source has completed.

@akarnokd
Copy link
Member

Can you create an unit test based on the usage pattern? It would be also interesting to verify replay().autoConnect() since it ought to be functionally equivalent to cache().

@abersnaze
Copy link
Contributor Author

I have no clue at the moment what the actual code path is causing the lockup. It'll take awhile for me to instrument code to narrow which usage pattern is causing the problem.

@benjchristensen
Copy link
Member

I believe the issue we're seeing comes from use of cache() in Hystrix: https://github.com/Netflix/Hystrix/blob/990394e98ba7472b96d90d7246e785d0966ade9a/hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java#L481

We use Hystrix at very high volume, and cache() will be used by a large percentage of those calls. This explains why this impacted our canary so significantly.

@abersnaze abersnaze changed the title Revert commit of f217edda0b4b5de8949ca3f3a15f6b7e8a963875 Revert of cache/replay Jul 18, 2015
@abersnaze
Copy link
Contributor Author

I've reverted both the cache and revert related commits. The tests and the canary seem to do fine so far.

benjchristensen added a commit that referenced this pull request Jul 20, 2015
@benjchristensen benjchristensen merged commit e4000b3 into ReactiveX:1.x Jul 20, 2015
@abersnaze abersnaze deleted the cache-rollback branch August 12, 2015 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants