test/subjects: Use statically imported never() methods #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and remove the unused Mockito imports
|
See #3291. |
|
@akarnokd are you seriously suggesting that cleaning up code to make it more consistent is a bad thing and shouldn't be done? |
|
Cosmetic PRs, especially on unit test or on internal classes, don't really contribute anything to the library. |
|
wow... |
|
I'm okay with this type of change. It makes the code more consistent, and is a simple non-intrusive change. |
benjchristensen
added a commit
that referenced
this pull request
Sep 11, 2015
test/subjects: Use statically imported never() methods
|
Thank you @Turbo87 for the contribution! |
|
@benjchristensen cool, thanks! |
|
@Turbo87 I apologize for my harsh and dry comments. Generally, I'm in favor of cleanups such as yours and would have done it the same way. I was under the false impression that the project doesn't want such cleanups. I'm sorry if I offended you. |
|
@akarnokd nevermind, seems it all worked out in the end ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and remove the unused Mockito imports