Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Operator #349

Merged
merged 5 commits into from
Sep 5, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
261 changes: 237 additions & 24 deletions rxjava-core/src/main/java/rx/Observable.java

Large diffs are not rendered by default.

599 changes: 599 additions & 0 deletions rxjava-core/src/main/java/rx/operators/ChunkedOperation.java

Large diffs are not rendered by default.

783 changes: 138 additions & 645 deletions rxjava-core/src/main/java/rx/operators/OperationBuffer.java

Large diffs are not rendered by default.

663 changes: 663 additions & 0 deletions rxjava-core/src/main/java/rx/operators/OperationWindow.java

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
*/
package rx.util;

public interface BufferClosing {
public interface Closing {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not a fan of these random classes/interfaces sitting in rx.util, but I can't think of anything better to do with them.

I don't really want them in rx and they don't seem to warrant their own package, but they seem different than util.

We could put them in Observable as inner classes but that may be a bad precedent if there are more of these cases down the road.

Does anyone else have a better idea of what to do with them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind much about them staying in rx.util for the timing being. I definitely wouldn't want them directly in rx, and Observable is already a monster. If somebody comes up with a great name for a package to put them into, I'm all for moving them, but otherwise, I'd leave them as is.

// Tagging interface for objects which can close buffers.
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
*/
package rx.util;

public class BufferClosings {
public class Closings {

public static BufferClosing create() {
return new BufferClosing() {};
public static Closing create() {
return new Closing() {};
}

private BufferClosings() {
private Closings() {
// Prevent instantation.
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
*/
package rx.util;

public interface BufferOpening {
public interface Opening {
// Tagging interface for objects which can open buffers.
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
*/
package rx.util;

public class BufferOpenings {
public class Openings {

public static BufferOpening create() {
return new BufferOpening() {};
public static Opening create() {
return new Opening() {};
}

private BufferOpenings() {
private Openings() {
// Prevent instantation.
}
}