-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window Operator #349
Merged
benjchristensen
merged 5 commits into
ReactiveX:master
from
benjchristensen:window-operator
Sep 5, 2013
Merged
Window Operator #349
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5789894
Merge window operator commit to master
09cac83
Merge branch 'OperationWindow' of https://github.com/RallySoftware/Rx…
benjchristensen 959b0d8
made WINDOW_MAKER typed
a7b40b3
removed raw Func0s from the chunks
92fe7f9
made the public window methods more generic via the basic (lol) super…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
599 changes: 599 additions & 0 deletions
599
rxjava-core/src/main/java/rx/operators/ChunkedOperation.java
Large diffs are not rendered by default.
Oops, something went wrong.
783 changes: 138 additions & 645 deletions
783
rxjava-core/src/main/java/rx/operators/OperationBuffer.java
Large diffs are not rendered by default.
Oops, something went wrong.
663 changes: 663 additions & 0 deletions
663
rxjava-core/src/main/java/rx/operators/OperationWindow.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not a fan of these random classes/interfaces sitting in
rx.util
, but I can't think of anything better to do with them.I don't really want them in
rx
and they don't seem to warrant their own package, but they seem different thanutil
.We could put them in
Observable
as inner classes but that may be a bad precedent if there are more of these cases down the road.Does anyone else have a better idea of what to do with them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind much about them staying in
rx.util
for the timing being. I definitely wouldn't want them directly inrx
, andObservable
is already a monster. If somebody comes up with a great name for a package to put them into, I'm all for moving them, but otherwise, I'd leave them as is.