1.x: Fix NPE in CompositeException when nested throws on initCause #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -122,6 +122,7 @@ public synchronized Throwable getCause() { | |||
| // ignore | |||
| // the javadocs say that some Throwables (depending on how they're made) will never | |||
| // let me call initCause without blowing up even if it returns null | |||
| chain = e; | |||
| } | |||
| chain = chain.getCause(); | |||
There was a problem hiding this comment.
I think this line should be moved into the try clause. Otherwise, chain will be assigned twice here.
akarnokd
changed the title
|
👍 @msavitskiy can you please squash commits in your PR into one? |
|
@artem-zinnatullin I make squash commits. I did the right thing? |
|
@msavitskiy mm, nope… Basically you should have one commit after squash done right. I'd suggest to read documentation and some examples (maybe even videos) about If it'll be blocker for merge I can squash your PR and resubmit it (you'll still be author of the commit!) |
Move line to try block. For avoid assigned twice.
|
@artem-zinnatullin Now everything is fine? |
|
@msavitskiy yes, thanks! |
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Feb 6, 2016
1.x: Fix NPE in CompositeException when nested throws on initCause
This was referenced Feb 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible solution :)