1.x: fix GroupBy delaying group completion till all groups were emitted #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| List<GroupedUnicast<K, V>> list = new ArrayList<GroupedUnicast<K, V>>(groups.values()); | ||
| groups.clear(); | ||
|
|
||
| for (GroupedUnicast<K, V> e : list) { |
There was a problem hiding this comment.
Why not just iterate over groups.values() here and avoid list allocation?
Or you want array structure for better performance? If so, not sure you're winning something big because you're iterating over values() in the constructor of ArrayList and then here.
There was a problem hiding this comment.
The idea was to reduce the window when terminating groups remove themselves from the map; but I don't think such case is likely anymore. I'll update the PR accordingly.
akarnokd
force-pushed
the
GroupByComplete1x
branch
from
2d13986 to
c8a2cfa
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.1.1,
groupBywas fixed to properly honor backpressure on the outerObservable. The change included a drain loop that emittedonCompleted()to the groups only when allGroupedObservables were drained from the main queue. This delayed the group's completion unnecessarily causing theconcatoperator to hang in some source-consumer cases such as #3775.This PR fixes the behavior by signalling
onCompleted()to the groups the moment the main completes.Note, however, that concatenating groups is eventually prone to hangs due to the groups not completing until the source completes, thus
concatcan't switch to the next source. One should useflatMaporconcatMapEagerinstead.