1.x: fix from(Iterable) error handling of Iterable/Iterator #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| o.onCompleted(); | ||
| else | ||
| } else { | ||
| o.setProducer(new IterableProducer<T>(o, it)); |
There was a problem hiding this comment.
Do we need to allocate and set the producer if unsubscribed? Seems like that check could enclose this whole if/else block.
|
👍 |
|
L93 no longer needs parameter void slowpath(long n) { |
|
👍 once last comment dealt with |
|
Actually, it should be using |
|
Yep I see, nice. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
from(Iterable)ignored non-fatal exceptions thrown by theIterableandIterator.Apart from wrapping the calls into
try-catch, the overal emission algorithm has been changed:hasNextonly once for each available value. Since the subscribe() checks for an outright emptyIterable, the drain loop runs only if it wasn't empty and does anotherhasNextcheck immediately to complete immediately if possible.