1.x: update map() and filter() to implement OnSubscribe directly #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 80.28%@@ 1.x #4097 diff @@
==========================================
Files 259 260 +1
Lines 16821 16852 +31
Methods 0 0
Messages 0 0
Branches 2554 2555 +1
==========================================
+ Hits 13500 13530 +30
+ Misses 2408 2405 -3
- Partials 913 917 +4
|
|
👍 |
|
Thanks @stevegury ! Could you give your opinion about #4098 as well? |
|
👍 // great that we have enough tests and coverage reports to perform such rewrites! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the indirection and allocation count when using
maporfilter.