1.x: Do not hide original exception with RxJavaHooks.enableAssemblyTracking() #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| StringBuilder sb = new StringBuilder("Assembly trace:"); | ||
|
|
||
| for (StackTraceElement e : stes) { | ||
| for (StackTraceElement e : in) { |
There was a problem hiding this comment.
I'll open separate PR after this one where I'll move filtering stacktrace to onError. This is a hot path while onError isn't, so we can save some CPU time on filtering for errorless chains.
Current coverage is 84.26%@@ 1.x #4213 diff @@
==========================================
Files 265 264 -1
Lines 17281 17279 -2
Methods 0 0
Messages 0 0
Branches 2617 2617
==========================================
+ Hits 14558 14560 +2
+ Misses 1881 1876 -5
- Partials 842 843 +1
|
|
See #4215 for a less invasive change. |
|
Closing in favor of #4215. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4212.