1.x: Completable.mergeDelayError check unsafe availability #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Dec 28, 2016
Current coverage is 84.23% (diff: 33.33%)@@ 1.x #4941 diff @@
==========================================
Files 288 288
Lines 17804 17806 +2
Methods 0 0
Messages 0 0
Branches 2697 2698 +1
==========================================
- Hits 15004 14999 -5
- Misses 1952 1953 +1
- Partials 848 854 +6
|
This was referenced Dec 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unconditional use of
MpscLinkedQueuewhen Unsafe is not available or has been disabled insideCompletableOnSubscribeMergeDelayErrorIterable.Related: #4940