Operation GroupByUntil #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #435 SUCCESS |
|
Needs to be rebased before it can merge. |
|
Will do shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #52
Note that Rx.NET's Subject once onCompleted() or onError()'d, any subsequent subscriptions from observers will immediately receive onCompleted() or onError(). RxJava's PublishSubject however doesn't seem to do that, leaving future observers never do anything. Since the Rx.NET.GroupByUntil relied on the described behavior to handle escaped groups, the proposed implementation inside the GroupSubject will do this manually.