Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: fix Completable.onErrorResumeNext unsubscribe not propagated #5225

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

akarnokd
Copy link
Member

The Completable.onErrorResumeNext did not properly propagate the downstream unsubscribe() call to upstream.

Reported in #5224.

@akarnokd akarnokd added this to the 1.3 milestone Mar 24, 2017
@codecov
Copy link

codecov bot commented Mar 24, 2017

Codecov Report

Merging #5225 into 1.x will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               1.x   #5225      +/-   ##
==========================================
- Coverage     84.5%   84.4%   -0.11%     
+ Complexity    2886    2883       -3     
==========================================
  Files          290     290              
  Lines        18123   18124       +1     
  Branches      2479    2479              
==========================================
- Hits         15315   15297      -18     
- Misses        1943    1963      +20     
+ Partials       865     864       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/rx/Completable.java 83.37% <100%> (+0.02%) 103 <0> (ø) ⬇️
.../java/rx/internal/util/unsafe/MpscLinkedQueue.java 75.75% <0%> (-12.13%) 9% <0%> (-1%)
.../rx/internal/operators/OperatorWindowWithTime.java 42.04% <0%> (-6.44%) 3% <0%> (ø)
...internal/subscriptions/SequentialSubscription.java 46.55% <0%> (-3.45%) 14% <0%> (-1%)
.../java/rx/internal/operators/BackpressureUtils.java 68.18% <0%> (-2.28%) 27% <0%> (-1%)
src/main/java/rx/observers/SerializedObserver.java 98.91% <0%> (-1.09%) 19% <0%> (-1%)
...n/java/rx/subjects/SubjectSubscriptionManager.java 80.71% <0%> (-0.72%) 15% <0%> (ø)
.../rx/internal/schedulers/CachedThreadScheduler.java 90.29% <0%> (+0.97%) 6% <0%> (ø) ⬇️
...a/rx/internal/operators/BufferUntilSubscriber.java 73.01% <0%> (+1.58%) 12% <0%> (+1%) ⬆️
...n/java/rx/internal/operators/CachedObservable.java 85.32% <0%> (+1.63%) 6% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7edee...51bd12a. Read the comment docs.

@akarnokd akarnokd merged commit e37d1a7 into ReactiveX:1.x Mar 24, 2017
@akarnokd akarnokd deleted the CompletableResumeNextFix branch January 9, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants