Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix documentation of Single.doAfterTerminate. #5403

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

mg6maciej
Copy link
Contributor

@mg6maciej mg6maciej commented Jun 9, 2017

Fix the copy-paste error in the javadoc of Single.doAfterTeminate mentioning doAfterSuccess.

@akarnokd
Copy link
Member

akarnokd commented Jun 9, 2017

I've updated the PR's description. Please, next time, don't leave the welcome message in there.

Otherwise, 👍

@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #5403 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5403      +/-   ##
============================================
- Coverage     96.09%   96.09%   -0.01%     
+ Complexity     5782     5780       -2     
============================================
  Files           630      630              
  Lines         41197    41197              
  Branches       5728     5728              
============================================
- Hits          39588    39587       -1     
+ Misses          635      630       -5     
- Partials        974      980       +6
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 132 <0> (ø) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.82% <0%> (-4.84%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 85.93% <0%> (-4.69%) 56% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 88.77% <0%> (-4.28%) 5% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 58.86% <0%> (-4.26%) 31% <0%> (-3%)
...ternal/operators/observable/ObservablePublish.java 91.22% <0%> (-3.51%) 9% <0%> (ø)
...ternal/operators/completable/CompletableCache.java 96.96% <0%> (-3.04%) 23% <0%> (-1%)
...operators/observable/ObservableConcatMapEager.java 97.26% <0%> (-2.19%) 2% <0%> (ø)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 97.95% <0%> (-2.05%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c174c45...f3d811e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants