-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LambdaConsumerIntrospection #5590
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
da4e67f
Implement HasDefaultErrorConsumer
ZacSweers ded2448
Add `@since`
ZacSweers 3f15c24
Add tests
ZacSweers e3882c6
Add support in relevant completable observers
ZacSweers b4f1509
Add support in ConsumerSingleObserver
ZacSweers 8d491eb
Add support in MaybeCallbackObserverTest
ZacSweers 4555b47
Add support in LambdaSubscriber
ZacSweers e2d06c0
Switch to CompositeObserver and onErrorImplemented()
ZacSweers bae194c
Update wording to use Introspection
ZacSweers 500df33
Update tests and flip implementation logic to match naming
ZacSweers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/main/java/io/reactivex/observers/LambdaConsumerIntrospection.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package io.reactivex.observers; | ||
|
||
import io.reactivex.annotations.Experimental; | ||
|
||
/** | ||
* An interface that indicates that the implementing type is composed of individual components and exposes information | ||
* about their behavior. | ||
* | ||
* <p><em>NOTE:</em> This is considered a read-only public API and is not intended to be implemented externally. | ||
* | ||
* @since 2.1.4 - experimental | ||
*/ | ||
@Experimental | ||
public interface LambdaConsumerIntrospection { | ||
|
||
/** | ||
* @return {@code true} if a custom onError consumer implementation was supplied. Returns {@code false} if the | ||
* implementation is missing an error consumer and thus using a throwing default implementation. | ||
*/ | ||
@Experimental | ||
boolean hasCustomOnError(); | ||
|
||
} |
25 changes: 25 additions & 0 deletions
25
src/test/java/io/reactivex/internal/observers/CallbackCompletableObserverTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package io.reactivex.internal.observers; | ||
|
||
import io.reactivex.internal.functions.Functions; | ||
import org.junit.Test; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
public final class CallbackCompletableObserverTest { | ||
|
||
@Test | ||
public void emptyActionShouldReportNoCustomOnError() { | ||
CallbackCompletableObserver o = new CallbackCompletableObserver(Functions.EMPTY_ACTION); | ||
|
||
assertFalse(o.hasCustomOnError()); | ||
} | ||
|
||
@Test | ||
public void customOnErrorShouldReportCustomOnError() { | ||
CallbackCompletableObserver o = new CallbackCompletableObserver(Functions.<Throwable>emptyConsumer(), | ||
Functions.EMPTY_ACTION); | ||
|
||
assertTrue(o.hasCustomOnError()); | ||
} | ||
|
||
} |
26 changes: 26 additions & 0 deletions
26
src/test/java/io/reactivex/internal/observers/ConsumerSingleObserverTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package io.reactivex.internal.observers; | ||
|
||
import io.reactivex.internal.functions.Functions; | ||
import org.junit.Test; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
public final class ConsumerSingleObserverTest { | ||
|
||
@Test | ||
public void onErrorMissingShouldReportNoCustomOnError() { | ||
ConsumerSingleObserver<Integer> o = new ConsumerSingleObserver<Integer>(Functions.<Integer>emptyConsumer(), | ||
Functions.ON_ERROR_MISSING); | ||
|
||
assertFalse(o.hasCustomOnError()); | ||
} | ||
|
||
@Test | ||
public void customOnErrorShouldReportCustomOnError() { | ||
ConsumerSingleObserver<Integer> o = new ConsumerSingleObserver<Integer>(Functions.<Integer>emptyConsumer(), | ||
Functions.<Throwable>emptyConsumer()); | ||
|
||
assertTrue(o.hasCustomOnError()); | ||
} | ||
|
||
} |
15 changes: 15 additions & 0 deletions
15
src/test/java/io/reactivex/internal/observers/EmptyCompletableObserverTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package io.reactivex.internal.observers; | ||
|
||
import org.junit.Test; | ||
|
||
import static org.junit.Assert.assertFalse; | ||
|
||
public final class EmptyCompletableObserverTest { | ||
|
||
@Test | ||
public void defaultShouldReportNoCustomOnError() { | ||
EmptyCompletableObserver o = new EmptyCompletableObserver(); | ||
|
||
assertFalse(o.hasCustomOnError()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we provide
hasDefaultOnError()
instead? cc @JakeWhartonBecause if you think about it from RxJava perspective — that's what library can say about itself: is something has a default value/implementation in compare to what library thinks is default.
hasCustomOnError()
basically checks forhasDefaultOnError()
and then negates the result which is kinda confusing.TL;TR: "custom" in the API feels wrong, but maybe it's just me :)