Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename interface parameters #5766

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Rename interface parameters #5766

merged 1 commit into from
Dec 19, 2017

Conversation

ShaishavGandhi
Copy link
Contributor

#5762

Signed-off-by: shaishavgandhi05 [email protected]

Signed-off-by: shaishavgandhi05 <[email protected]>
@codecov
Copy link

codecov bot commented Dec 17, 2017

Codecov Report

Merging #5766 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5766      +/-   ##
============================================
+ Coverage     96.24%   96.28%   +0.03%     
- Complexity     5805     5809       +4     
============================================
  Files           634      634              
  Lines         41607    41607              
  Branches       5770     5770              
============================================
+ Hits          40046    40062      +16     
+ Misses          622      617       -5     
+ Partials        939      928      -11
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.33% <0%> (-4.35%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-2.5%) 2% <0%> (ø)
...a/io/reactivex/internal/queue/MpscLinkedQueue.java 98.03% <0%> (-1.97%) 17% <0%> (-1%)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
...nal/operators/flowable/FlowableConcatMapEager.java 97.1% <0%> (-1.16%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 92.1% <0%> (-0.88%) 10% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
...main/java/io/reactivex/subjects/ReplaySubject.java 96.67% <0%> (-0.67%) 48% <0%> (ø)
...ivex/internal/operators/parallel/ParallelJoin.java 94.5% <0%> (-0.37%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (ø) 2% <0%> (ø) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba9a3e...03f27ce. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 milestone Dec 17, 2017
Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yiss 👍 , also wanted to do it for a long time but thought that David won't be happy to merge this haha

@akarnokd akarnokd merged commit 3096024 into ReactiveX:2.x Dec 19, 2017
@EGecius
Copy link

EGecius commented Dec 21, 2017

good work +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants