Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Cleanup, coverage and related component fixes #5889

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Mar 4, 2018

This PR improves the coverage of various components and contains the following additional fixes:

  • Remove a very unlikely cancellation check in FlowableConcatMapEager.
  • Improve backpressure tracking in FlowablePublishMulticast to avoid atomic decrement per items emitted (part of publish(Function)).
  • Improve check for empty or terminated state in FlowablePublishMulticast by using the array length.
  • UnicastProcessor termination to use a one-step getAndSet
  • BehaviorSubject termination to use a one-step getAndSet
  • Remove impossible try-finally in BehaviorSubject.setCurrent as the body could never crash.

@akarnokd akarnokd added this to the 2.2 milestone Mar 4, 2018
@codecov
Copy link

codecov bot commented Mar 4, 2018

Codecov Report

Merging #5889 into 2.x will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5889      +/-   ##
============================================
+ Coverage     97.49%   97.57%   +0.07%     
- Complexity     5946     5956      +10     
============================================
  Files           655      655              
  Lines         43900    43897       -3     
  Branches       6108     6106       -2     
============================================
+ Hits          42799    42831      +32     
+ Misses          339      333       -6     
+ Partials        762      733      -29
Impacted Files Coverage Δ Complexity Δ
...nal/operators/flowable/FlowableConcatMapEager.java 98.24% <ø> (-0.03%) 2 <0> (ø)
...l/operators/flowable/FlowablePublishMulticast.java 100% <100%> (+6.52%) 2 <0> (ø) ⬇️
...in/java/io/reactivex/subjects/BehaviorSubject.java 96.23% <100%> (-2.18%) 54 <1> (ø)
...java/io/reactivex/processors/UnicastProcessor.java 100% <100%> (+4.16%) 68 <2> (+6) ⬆️
...ternal/operators/observable/ObservablePublish.java 92.98% <0%> (-3.51%) 11% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 95.96% <0%> (-3.14%) 59% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 96.66% <0%> (-1.67%) 2% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-1.45%) 2% <0%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855153e...cb6b669. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants