Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Nullable annotations to Processors #5925

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

aaronweihe
Copy link
Contributor

Add @Nullable annotations to Processors.

Updated our project to use 2.11.1, and discovered there's this PR #5890 which added @Nullable annotations to Subjects. Thought might as well add @Nullable to Processors.

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #5925 into 2.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5925      +/-   ##
============================================
- Coverage     98.28%   98.27%   -0.02%     
+ Complexity     6021     6019       -2     
============================================
  Files           656      656              
  Lines         44040    44040              
  Branches       6102     6102              
============================================
- Hits          43284    43279       -5     
- Misses          223      227       +4     
- Partials        533      534       +1
Impacted Files Coverage Δ Complexity Δ
...ava/io/reactivex/processors/BehaviorProcessor.java 99.1% <ø> (ø) 60 <0> (ø) ⬇️
.../java/io/reactivex/processors/ReplayProcessor.java 99.58% <ø> (ø) 52 <0> (ø) ⬇️
...java/io/reactivex/processors/UnicastProcessor.java 100% <ø> (ø) 68 <0> (ø) ⬇️
...n/java/io/reactivex/processors/AsyncProcessor.java 99.08% <ø> (ø) 52 <0> (ø) ⬇️
...java/io/reactivex/processors/PublishProcessor.java 100% <ø> (+1.76%) 44 <0> (+1) ⬆️
...a/io/reactivex/processors/SerializedProcessor.java 97.87% <ø> (ø) 28 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 88.88% <0%> (-7.19%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-2.72%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88aa854...3d75f35. Read the comment docs.

@akarnokd akarnokd added the 2.x label Mar 22, 2018
@akarnokd akarnokd added this to the 2.2 milestone Mar 22, 2018
@akarnokd akarnokd merged commit f363ef0 into ReactiveX:2.x Mar 22, 2018
@aaronweihe aaronweihe deleted the ahe/nullable-processors branch March 22, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants