Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eager concats to Single #5976

Merged
merged 7 commits into from
Apr 29, 2018
Merged

Adding eager concats to Single #5976

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d15e07
Adding eager concats to Single
Desislav-Petrov Apr 28, 2018
210b224
Removing unnecessary class - the utility already exists
Desislav-Petrov Apr 28, 2018
3eeab3c
Covering publisher sequence
Desislav-Petrov Apr 28, 2018
66a8c3b
Correcting javadoc
Desislav-Petrov Apr 28, 2018
1625f62
Correcting javadoc
Desislav-Petrov Apr 28, 2018
4e27c83
Fixing javadoc "Single sources" -> "SingleSources"
Desislav-Petrov Apr 28, 2018
0fc54dd
Fixing javadoc "Maybe sources" -> "MaybeSources"
Desislav-Petrov Apr 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/reactivex/Single.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public static <T> Flowable<T> concatArrayEager(SingleSource<? extends T>... sour
}

/**
* Concatenates a Publisher sequence of Publishers eagerly into a single stream of values.
* Concatenates a Publisher sequence of Single sources eagerly into a single stream of values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SingleSources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.. i can see this "Single sources" instead of SingleSources in a few other places within the Javadoc of the Single class - guess we should fix all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I think they are remnants from the time when there was no SingleSource interface yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see - fixed in all places within the Single class.

* <p>
* Eager concatenation means that once a subscriber subscribes, this operator subscribes to all of the
* emitted source Publishers as they are observed. The operator buffers the values emitted by these
Expand Down