Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Small cleanups in the Scheduler class #5985

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

akarnokd
Copy link
Member

  • Remove @NonNull from a primitive type
  • Make the package-private PeriodicDirectTask final
  • Add @NonNull to other fields

@akarnokd akarnokd added this to the 2.2 milestone Apr 30, 2018
@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

Merging #5985 into 2.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5985      +/-   ##
============================================
- Coverage     98.27%   98.26%   -0.02%     
+ Complexity     6051     6050       -1     
============================================
  Files           656      656              
  Lines         44078    44078              
  Branches       6118     6118              
============================================
- Hits          43318    43312       -6     
- Misses          226      231       +5     
- Partials        534      535       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Scheduler.java 100% <100%> (ø) 11 <0> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 93.04% <0%> (-5.22%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 96.52% <0%> (-3.48%) 55% <0%> (-3%)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.56% <0%> (-2.18%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.27% <0%> (-1.45%) 2% <0%> (ø)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
...ivex/internal/operators/maybe/MaybeMergeArray.java 96.62% <0%> (-1.13%) 6% <0%> (ø)
...perators/mixed/ObservableConcatMapCompletable.java 99.24% <0%> (-0.76%) 3% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-0.75%) 2% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f9a83...48c46c2. Read the comment docs.

@akarnokd akarnokd merged commit 59cf89c into ReactiveX:2.x Apr 30, 2018
@akarnokd akarnokd deleted the SchedulerCleanup430 branch April 30, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants