2.x: Single.flatMapPublisher full implementation #6021
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6021 +/- ##
============================================
+ Coverage 98.29% 98.29% +<.01%
- Complexity 6163 6166 +3
============================================
Files 659 660 +1
Lines 44521 44557 +36
Branches 6201 6201
============================================
+ Hits 43760 43799 +39
- Misses 226 228 +2
+ Partials 535 530 -5
Continue to review full report at Codecov.
|
| import io.reactivex.internal.functions.ObjectHelper; | ||
| import io.reactivex.internal.subscriptions.SubscriptionHelper; | ||
|
|
||
| public final class SingleFlatMapPublisher<S, T> extends Flowable<T> { |
There was a problem hiding this comment.
Please add a JavaDoc here (you can copy the docs from the operator) that includes @since 2.1.15 (no need for experimental). Also it would be great of the type arguments would be T, R.
| } | ||
|
|
||
| static final class SingleFlatMapPublisherObserver<S, T> extends AtomicLong | ||
| implements SingleObserver<S>, Subscriber<T>, Subscription { |
There was a problem hiding this comment.
Please FlowableSubscriber, otherwise the safety layer is added as a mapped Flowable will think it talks to an arbitrary consumer.
There was a problem hiding this comment.
Thanks, I'll go and check my other libraries for that one.
|
|
||
| final Subscriber<? super T> actual; | ||
| final Function<? super S, ? extends Publisher<? extends T>> mapper; | ||
| final AtomicReference<Subscription> parent = new AtomicReference<Subscription>(); |
There was a problem hiding this comment.
Nit: initialize in constructor?
| public void onSuccess(S value) { | ||
| Publisher<? extends T> f; | ||
| try { | ||
| f = ObjectHelper.requireNonNull(mapper.apply(value), "mapper returns null"); |
There was a problem hiding this comment.
Usually it says The mapper returned a null Publisher.
| Publisher<? extends T> f; | ||
| try { | ||
| f = ObjectHelper.requireNonNull(mapper.apply(value), "mapper returns null"); | ||
| } catch (Exception e) { |
davidmoten
force-pushed
the
single-flat-map-publisher-full
branch
from
6a5c9aa to
e5244e9
Compare
davidmoten
force-pushed
the
single-flat-map-publisher-full
branch
from
e5244e9 to
377b6e2
Compare
|
I've made those changes. |
See discussion in #6015.
Resolves: #6015