Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Improve Completable.delay operator internals #6096

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

akarnokd
Copy link
Member

This PR improves the Completable.delay() operator internals, reducing allocation and indirection.

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #6096 into 2.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6096      +/-   ##
============================================
+ Coverage     98.26%   98.26%   +<.01%     
- Complexity     6194     6198       +4     
============================================
  Files           667      667              
  Lines         44858    44862       +4     
  Branches       6211     6213       +2     
============================================
+ Hits          44081    44085       +4     
- Misses          234      235       +1     
+ Partials        543      542       -1
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/completable/CompletableDelay.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...o/reactivex/internal/schedulers/SchedulerWhen.java 97.64% <0%> (-2.36%) 5% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 97.44% <0%> (-1.71%) 11% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 94.68% <0%> (-1.6%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.2% <0%> (-1.45%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 96.93% <0%> (-1.03%) 2% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.06% <0%> (-0.94%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 86.58% <0%> (-0.64%) 3% <0%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aeac06...0c4d008. Read the comment docs.

@akarnokd akarnokd merged commit 27c63b6 into ReactiveX:2.x Jul 19, 2018
@akarnokd akarnokd deleted the CompletableDelayImprove branch July 19, 2018 08:45
Copy link
Collaborator

@davidmoten davidmoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

final class Delay implements CompletableObserver {
static final class Delay extends AtomicReference<Disposable>
implements CompletableObserver, Runnable, Disposable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants