-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Improve Completable.delay operator internals #6096
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6096 +/- ##
============================================
+ Coverage 98.26% 98.26% +<.01%
- Complexity 6194 6198 +4
============================================
Files 667 667
Lines 44858 44862 +4
Branches 6211 6213 +2
============================================
+ Hits 44081 44085 +4
- Misses 234 235 +1
+ Partials 543 542 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
|
||
final class Delay implements CompletableObserver { | ||
static final class Delay extends AtomicReference<Disposable> | ||
implements CompletableObserver, Runnable, Disposable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat
This PR improves the
Completable.delay()
operator internals, reducing allocation and indirection.