Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marble diagrams for various Single operators #6141

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

UMFsimke
Copy link
Contributor

@UMFsimke UMFsimke commented Aug 5, 2018

Here are marble diagrams for various Single operators that will close some of the #5788

Marble for concatEager(Publisher)
concateEagerP

Marble for concatEager(Iterable)
concateEagerI

Marble for create
create

Marble for ambWith
ambWith

Marble for equals
equals

Marble for merge(source1, source2)
merge

Marble for merge(source1, source2, source3)
mergeThree

Marble for merge(source1, source2, source3, source4)
mergeFour

Marble for merge(SingleSource<SingleSource>)
mergeSingleSource

Marble for mergeWith
mergeWith

Marble for doAfterTerminate
doAfterTerminate

Marble for to
to

Marble for as
as

Marble for compose
compose

Marble for doAfterSuccess
doAfterSuccess

Marble for merge(Publisher)
mergePublisher

Marble for merge(Iterable)
mergeIterable

@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #6141 into 2.x will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6141      +/-   ##
============================================
- Coverage     98.28%   98.23%   -0.05%     
  Complexity     6193     6193              
============================================
  Files           667      667              
  Lines         44853    44853              
  Branches       6213     6213              
============================================
- Hits          44082    44061      -21     
- Misses          235      244       +9     
- Partials        536      548      +12
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <100%> (ø) 146 <3> (ø) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 95.72% <0%> (-3.42%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.23% <0%> (-3.39%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 95.96% <0%> (-3.14%) 59% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 90.19% <0%> (-2.62%) 2% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...vex/internal/operators/single/SingleTakeUntil.java 98.3% <0%> (-1.7%) 2% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579e90d...7a6b390. Read the comment docs.

@akarnokd akarnokd merged commit 3562dfc into ReactiveX:2.x Aug 5, 2018
@UMFsimke
Copy link
Contributor Author

UMFsimke commented Aug 5, 2018

@akarnokd create marble is not valid.... I havent pushed correct version to the repo.... sorry for this.

Here is proper create:
create

@akarnokd
Copy link
Member

akarnokd commented Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants