-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused else from the Observable #6485
Conversation
import org.reactivestreams.Publisher; | ||
|
||
import io.reactivex.annotations.*; | ||
import java.util.Collection; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not unroll star imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akarnokd Maybe you can include some rule for the import bloc to CONTRIBUTING.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When submitting code, please make every effort to follow existing conventions and style in order to keep the code as readable as possible.
But don't worry, we will warn you if there is a stylistic problem.
Codecov Report
@@ Coverage Diff @@
## 2.x #6485 +/- ##
============================================
- Coverage 98.28% 98.24% -0.05%
+ Complexity 6297 6294 -3
============================================
Files 675 675
Lines 45159 45159
Branches 6244 6244
============================================
- Hits 44384 44365 -19
- Misses 243 248 +5
- Partials 532 546 +14
Continue to review full report at Codecov.
|
Remove unused else from the Observable class.