3.x: Fix refCount not resetting when termination triggers cross-cancel #6609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes both
refCount
implementation to properly reset the source when the source terminates multiple consumers.In the original, when the source terminated multiple sources, the first termination handler cleared the connection but since the
--subscriberCount
wasn't zero, the source was not reset. If this termination triggered a cancel on the second consumer, that path would not get the source reset either due to losing the connection object. Unfortunately, one can't just take the first termination handler and reset there immediately either because that could disrupt the termination of the rest of the consumers. It has to wait for the source to terminate all consumers or have the consumers cancel all.This affects 2.x and will be backported in a separate PR.
Fixes #6608