Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Remove vararg overloads for combineLatest in Observable + Flowable #6635

Merged
merged 1 commit into from
Aug 28, 2019
Merged

3.x: Remove vararg overloads for combineLatest in Observable + Flowable #6635

merged 1 commit into from
Aug 28, 2019

Conversation

vanniktech
Copy link
Collaborator

Started removing the vararg function from #6634

@vanniktech
Copy link
Collaborator Author

vanniktech commented Aug 27, 2019

Hmm after looking at the tests the varag variant for combineLatestDelayError might be useful since there are no 2-x overloads available. What do you think?

@akarnokd
Copy link
Member

Let me guess, IntelliJ refactor?

@akarnokd
Copy link
Member

The varargs is a convenience over the array variant so combineLatestDelayErrors can go.

@akarnokd akarnokd added this to the 3.0 milestone Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #6635 into 3.x will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6635      +/-   ##
============================================
- Coverage     98.16%   98.16%   -0.01%     
  Complexity     6182     6182              
============================================
  Files           678      678              
  Lines         44801    44795       -6     
  Branches       6177     6177              
============================================
- Hits          43981    43974       -7     
- Misses          278      281       +3     
+ Partials        542      540       -2
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 562 <0> (-3) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 538 <0> (-2) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 88.88% <0%> (-5.56%) 2% <0%> (ø)
...eactivex/rxjava3/processors/BehaviorProcessor.java 96.58% <0%> (-2.44%) 51% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 96.79% <0%> (-1.07%) 5% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.28% <0%> (-0.79%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 94.89% <0%> (-0.73%) 2% <0%> (ø)
.../operators/observable/ObservableCombineLatest.java 96.31% <0%> (-0.62%) 6% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97790c6...d56dc2e. Read the comment docs.

@akarnokd akarnokd merged commit faf6392 into ReactiveX:3.x Aug 28, 2019
@vanniktech vanniktech deleted the vararg branch August 28, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants