-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Move nullability annotations into the type argument declaration #7303
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #7303 +/- ##
============================================
- Coverage 99.53% 99.50% -0.03%
+ Complexity 6783 6781 -2
============================================
Files 751 751
Lines 47489 47489
Branches 6378 6378
============================================
- Hits 47266 47253 -13
- Misses 102 110 +8
- Partials 121 126 +5
Continue to review full report at Codecov.
|
This is great!! Will be a big win for nullaway users and kotlin users starting in 1.5.30. |
This PR makes sure generic type argument declarations on methods include the
@NonNull
(or@Nullable
) annotation as well as source-checking test code to verify the expected style.Before:
After:
Related #7302