-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported groupByUntil function to scala-adapter #732
Conversation
RxJava-pull-requests #646 SUCCESS |
Thanks @chrisgrimm for contributing! Some comments:
|
@samuelgruetter |
If you get these changes in today I'll release tomorrow (Tuesday US time). |
@benjchristensen Sorry for the delay I just woke up. I added the example, changed the groupByUntil operator so that the conversion in the scala adapter wasn't necessary, and changed the signature of the closings function to include the key of the group in question. |
RxJava-pull-requests #666 SUCCESS |
Thanks @chrisgrimm |
Ported groupByUntil function to scala-adapter
Ported the groupByUntil function to scala-adapter. This is my first time contributing, please let me know if anything is off.