Rxjava clojure bindings final #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported code, fixed namespaces and adusted one test for changes since 0.14.1.
presumably the group ID should be the same for gradle as for the other dependency managers.
Automating "rx.exceptions.OnErrorThrowable/addValueAsLastCause" idiom when user code is invoked in onNext. Other minor cleanup.
Note that since 02ccc4d, the val-fn variant of groupBy is unimplemented so for now an exception is thrown if it's used.
There isn't really an rxjava impl equivalent to clojure.core/partition, so it's omitted.
Split merge into merge/merge* for consistency with other functions that can take one or more observables or observable of observables.
Base on @mbossenbroek's feedback. Seems like an improvement.
Closed
|
RxJava-pull-requests #867 FAILURE |
|
Very nice :-) Looks like the build failure is a non-deterministic signing issue with Scala so merging. |
benjchristensen
added a commit
that referenced
this pull request
Feb 25, 2014
Rxjava clojure bindings final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clojure bindings for RxJava. Rebased and cleaned up version of #908 ready for merge. Didn't really get any external feedback, so I'm assuming that means it's perfect :)