Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quasar integration contrib module #990

Merged
merged 14 commits into from
Apr 2, 2014
Merged

Conversation

pron
Copy link
Contributor

@pron pron commented Mar 26, 2014

This module integrates RxJava with Quasar in several ways. It provides:

  • A fiber-based scheduler
  • A fiber-blocking version of BlockingObservables
  • Viewing Quasar channels as Observables and transforming Observables into channels (Quasar channels are a CSP mechanism very similar to channels in the Go programming language).

@cloudbees-pull-request-builder

RxJava-pull-requests #924 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

This looks great!

I need to update the build job to use JDK 7 for this module if this can't work with Java 6. Is that the case (that's fine if so as it's not targeting Android).

@pron
Copy link
Contributor Author

pron commented Mar 26, 2014

Right (we plan to add Android support in version 0.7).

@benjchristensen
Copy link
Member

Does that mean you will downgrade from Java 7 to Java 6?

@benjchristensen
Copy link
Member

Since your code states VERSION_1_6 for source, can you change the target to 1.6 as well so it builds without changing our build server?

@benjchristensen
Copy link
Member

Based on your build.gradle the source complies with Java 6. If that's the case all that is needed is changing the target to Java 6 as well and it will build on our server.

@pron
Copy link
Contributor Author

pron commented Mar 27, 2014

Seems to build...

@cloudbees-pull-request-builder

RxJava-pull-requests #926 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

RxJava-pull-requests #927 FAILURE
Looks like there's a problem with this pull request

doesn't compile b/c channels implement AutoCloseable, added in JDK 7.
@cloudbees-pull-request-builder

RxJava-pull-requests #928 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

So it looks like your code does indeed need Java 7?

@pron
Copy link
Contributor Author

pron commented Mar 27, 2014

Yeah, seems so. Well Quasar requires 7, but I thought we might be able to
get away with compiling this module on 6. Apparently not...
On Mar 27, 2014 7:38 PM, "Ben Christensen" [email protected] wrote:

So it looks like your code does indeed need Java 7?


Reply to this email directly or view it on GitHubhttps://github.com//pull/990#issuecomment-38835973
.

@benjchristensen
Copy link
Member

Okay, I'll need to spend some time validating that our build is okay after I migrate the build server to using 7. Once I do that then I'll merge this.

benjchristensen added a commit that referenced this pull request Apr 2, 2014
Quasar integration contrib module
@benjchristensen benjchristensen merged commit 2e95862 into ReactiveX:master Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants