[do not yet merge] ChangeEventSource & fromChangeEvents #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's how I would add a
ChangeEventSource
andSwingObservable.fromChangeEvents(...)
methods.The problem is that the many Swing classes which have
addChangeListener
andremoveChangeListener
methods don't implement a common interface or super class, so we need to write a separatefromChangeEvents
overload for each such Swing class.So the goal is to have no code duplication except at the place where we have to show to the Java compiler that the Swing class in question indeed has
addChangeListener
andremoveChangeListener
methods. This PR gives one way of achieving this, comments/feedback are welcome ;-)Note that this PR is not yet complete: It has no tests yet, needs more
fromChangeEvents
overloads, and probably also some doc improvements. I don't have time to continue on this right now, but everyone please feel free to branch from here and continue ;-)