Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): SearchResultItem.fromJson type error #627

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

wayne900204
Copy link
Contributor

@wayne900204 wayne900204 commented Sep 13, 2021

If it uses Object will error.
My sdk is not >2.14, So I am not sure it is a bug, but I think it is a bug. because I searched history commit, no one changed this. see: #628

@hoc081098 hoc081098 linked an issue Sep 13, 2021 that may be closed by this pull request
Copy link
Collaborator

@hoc081098 hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error has occurred since null-safety is enabled.
Thanks @wayne900204

@codecov-commenter
Copy link

Codecov Report

Merging #627 (53907a3) into master (c516f91) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files          73       73           
  Lines        2256     2256           
=======================================
  Hits         2098     2098           
  Misses        158      158           

@hoc081098 hoc081098 merged commit 5c766c5 into ReactiveX:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]RxDart Example github_search error
3 participants