Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary if statement in Observable.prototype.pipe #6504

Closed
hgaleh opened this issue Jul 5, 2021 · 2 comments
Closed

unnecessary if statement in Observable.prototype.pipe #6504

hgaleh opened this issue Jul 5, 2021 · 2 comments

Comments

@hgaleh
Copy link
Contributor

hgaleh commented Jul 5, 2021

There is an unnecessary if statement in the Observable.prototype.pipe because length is double checked.
hgaleh added a commit to hgaleh/rxjs that referenced this issue Jul 5, 2021
@hgaleh
refactor(Observable): remove unnecessary if
7c6d022 
there is an unnecessary if in the pipe, remove it

ReactiveX#6504
@hgaleh hgaleh mentioned this issue Jul 5, 2021
Merged
hgaleh added a commit to hgaleh/rxjs that referenced this issue Jul 7, 2021
@hgaleh
refactor(Observable): remove unnecessary if
591b996 
there is an unnecessary if in the pipe, remove it

ReactiveX#6504
hgaleh added a commit to hgaleh/rxjs that referenced this issue Jul 9, 2021
@hgaleh
refactor(Observable): remove unnecessary if
921ed75 
there is an unnecessary if in the pipe, remove it

ReactiveX#6504
hgaleh added a commit to hgaleh/rxjs that referenced this issue Jul 11, 2021
@hgaleh
refactor(Observable): remove unnecessary if
45dc38d 
there is an unnecessary if in the pipe, remove it

ReactiveX#6504
benlesh pushed a commit that referenced this issue Jul 14, 2021
refactor(Observable): remove unnecessary if (#6505)
938e211 
there is an unnecessary if in the pipe, remove it

#6504
@rluvaton
Copy link

Can be closed as the PR #6505 fixed this

@jakovljevic-mladen
Copy link
Member

Closing as fixed in #6505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rluvaton @hgaleh @jakovljevic-mladen