Bug report: # of activity lines remains the same after I change max_lines property

[jooncco]

Checks

• I use a supported version of Recent Activity.
• I searched the issues page for already existing bug reports.

Description

The number of activity lines remains the same after I change max_lines property

Steps to reproduce

1. Run workflow with default settings.
2. Change the max_lines property value inside .github/recent-activity.config.yml into 8.
3. Re-run the workflow.

Configuration

name: Recent activity

on:
  schedule:
    - cron: '*/30 * * * *' # Update every 30 minutes
  workflow_dispatch:

jobs:
  build:
    runs-on: ubuntu-latest
    name: Update this repo's README with recent activity

    steps:
      - uses: actions/[email protected]
      - uses: Readme-Workflows/[email protected]
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

---

settings:
  username: "jooncco"
  commit_msg: "⚡ Update README with the recent activity"
  max_lines: 8
  readme_file: "./README.md"
  disabled_events:
    - "comments"
  url_text: "{REPO}{ID}"
  date:
    timezone: "GMT+09:00"
    text: "Last Updated: {DATE}"
    format: "dddd, mmmm dS, yyyy, h:MM:ss TT"
  commit_name: "readme-bot"
  commit_email: "41898282+github-actions[bot]@users.noreply.github.com"
messages:
  comments: "💬 Commented on {ID} in {REPO}"
  issue_opened: "❗️ Opened issue {ID} in {REPO}"
  issue_closed: "✔️ Closed issue {ID} in {REPO}"
  pr_opened: "💪 Opened PR {ID} in {REPO}"
  pr_closed: "❌ Closed PR {ID} in {REPO}"
  pr_merged: "🎉 Merged PR {ID} in {REPO}"
  create_repo: "📔 Created new repository {REPO}"
  fork_repo: "🔱 Forked {FORK} from {REPO}"
  wiki_create: "📖 Created new wiki page {WIKI} in {REPO}"
  added_member: "🤝 Became collaborator on {REPO}"
  changes_approved: "👍 Approved {ID} in {REPO}"
  changes_requested: "🔴 Requested changes in {ID} in {REPO}"
  new_release: "✌️ Released {ID} in {REPO}"
  new_star: "⭐ Starred {REPO}"

Expected behaviour

newest 8 activity lines are showing

Actual behaviour

newest 5 activity lines are showing

Failed runs

No response

[welcome]

Thanks for opening your first issue here! Your contribution is welcome🙏. Make sure to follow the code of conduct!

[Andre601]

This is mentioned in the wiki:
https://github.com/Readme-Workflows/recent-activity/wiki/Configuration#max_lines

The action will continue until it reached the amount of lines or the stop comment.

[jooncco]

Oh I missed it, thanks.
Now this issue should be a new feature request I think 🤔.