fix: # of activity lines changes according to max_lines property

[jooncco]

Checks

I have...

• read and understood the Contributing Guidelines
• Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

• Minor Change
  This Pull request doesn't break existing configuration.
• Major Change
  This Pull request will break existing configuration.
• Bug fix
  This Pull request will fix a (critical) bug.
• Documentation
  This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
• Other: __________

Description

This pull request fixes #159.
The number of activity lines will change according to max_lines property every time workflow runs.

Closes #159

[abhijoshi2k]

This cannot be done because when user changes max-lines parameter, this might result into content lines being overwritten.
The simple solution here is to reset the workflow manually by removing the recent activity lines (run it as if running for first time)

[jooncco]

This cannot be done because when user changes max-lines parameter, this might result into content lines being overwritten. The simple solution here is to reset the workflow manually by removing the recent activity lines (run it as if running for first time)

Thanks for the reply, @abhijoshi2k.
My changes doesn't affect other contents in README.md.

readmeContent.splice(startIdx, endIdx-startIdx);

This line limits the deletion into only [startIdx, endIdx).

[jooncco]

And thanks for the simple solution.
I actually was aware of that, but wanted to suggest this kind of feature.

[abhijoshi2k]

I'll test it once and get back to you. I'm a bit occupied currently. Give me some time.

[abhijoshi2k]

@jooncco Thanks for the PR. I just tested your edited code. It works as expected. So I think this is ready to be merged.
@PuneetGopinath I am approving this. Please check and merge.

[jooncco]

appreciate it :)

[kaustav202]

@PuneetGopinath @abhijoshi2k @jooncco I am still facing the issue . I've tried removing the recent activity comment to no avail. It always limits to 5 activities only. Kindly let me know if there's any workaround to it. Thank you.

[Andre601]

Did you actually update your settings?
Also, please open a discussion for support.

[kaustav202]

Yes, it's working alright. Needed to change path for the config file ( added custom ).